fix: Inject Javascript to Remove Service Worker on iOS from WkWebView #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w. Remove Service workers from all websites on iOS in the WkWebView to prevent the crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a problem with opening some websites which rely on Service Workers and don't handle their unavailable state. For example, https://www.niftyisland.com is crashing on iOS:
Screenshot
Service Workers are not supported on iOS in WkWebView:
https://developer.apple.com/forums/thread/773539
https://stackoverflow.com/questions/63674612/wkwebview-service-workers
To prevent such crashes we can inject Javascript code to mock Service Workers if they're not supported. This mock won't do anything except preventing the problem.
Screenshot of working website