revert: remove feature-flags to user traits tracking (PR #24178)

[NicolasMassart]

Description

This reverts the changes from PR #24178 that added automatic tracking of remote feature flags to user traits via addTraitsToUser.
Automatic Github revert not available for this PR.

Reverted changes:

• Removed useEffect hook that called addTraitsToUser with rawFeatureFlags
• Removed useMetrics import and addTraitsToUser usage
• Removed related unit tests for feature flag user traits tracking

Related

Reverts #24178

Changelog

CHANGELOG entry: null

Related issues

Reverts #24178

Manual testing steps

Identify calls should be sent to Segment server again.

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Reverts automatic syncing of remote feature flags to user traits.

• Removes useMetrics import and the useEffect that called addTraitsToUser(rawFeatureFlags) in FeatureFlagOverrideContext.tsx
• Deletes related unit tests and mocks in FeatureFlagOverrideContext.test.tsx for bulk/add-on-change trait updates
• Keeps feature flag override functionality (set/remove/clear) intact

^{Written by Cursor Bugbot for commit 27ec9cd. This will update automatically on new commits. Configure here.}

[Copilot]

Pull request overview

This PR reverts the automatic tracking of remote feature flags to user traits that was introduced in PR #24178. The revert removes the feature flag tracking functionality while preserving all core feature flag override APIs and processing logic.

• Removes automatic user trait tracking when feature flags are loaded or changed
• Eliminates the useMetrics hook dependency from the FeatureFlagOverrideContext
• Removes all associated unit tests for the reverted feature flag tracking functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
app/contexts/FeatureFlagOverrideContext.tsx	Removed useEffect import, useMetrics hook, and the effect that automatically tracked feature flags to user traits
app/contexts/FeatureFlagOverrideContext.test.tsx	Removed useMetrics mock setup and all test cases covering the automatic feature flag tracking functionality

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Gudahtt]

Looks good once the lint error is fixed

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[Gudahtt]

LGTM!

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAnalytics
• Risk Level: low
• AI Confidence: 85%

click to see 🤖 AI reasoning details

The changes remove analytics tracking functionality from the FeatureFlagOverrideContext. Specifically, the code that was calling addTraitsToUser(rawFeatureFlags) to track feature flags as user traits has been removed, along with the useMetrics hook import and the useEffect that triggered this tracking.

This is a clean removal of analytics-related code:

1. The core feature flag override functionality (getting, setting, clearing overrides) remains completely intact
2. The FeatureFlagOverrideProvider still works the same way for all other purposes
3. Only the automatic analytics tracking of feature flags to user traits is removed
4. The test file changes appropriately remove tests for the removed functionality

Since this change only affects analytics tracking and doesn't modify any user-facing features or core wallet functionality, the risk is low. The SmokeAnalytics tag is selected to verify that analytics functionality still works correctly after this change, as the removal of this tracking code could potentially affect analytics data collection patterns.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud