Skip to content

Conversation

@gabrieledm
Copy link
Contributor

@gabrieledm gabrieledm commented Jan 5, 2026

Description

This PR adds:

Changelog

CHANGELOG entry: Add BOB network and native token logos.
CHANGELOG entry: Add Rootstock network and native token logos.

Related issues

Fixes:

Manual testing steps

BOB

  1. Open mobile app
  2. Using "Search", go to https://chainlist.org/?search=bob
  3. Click on Add to MetaMask Button of BOB (ChainID 60808)
  4. After accepting, It should add the network to your MetaMask
  5. The network icon should show correctly
  6. Ethereum should show up as native token with a logo

Rootstock

  1. Open mobile app
  2. Using "Search", go to https://chainlist.org/?search=rootstock
  3. Click on Add to MetaMask Button of Rootstock (ChainID 30)
  4. After accepting, It should add the network to your MetaMask
  5. The network icon should show correctly
  6. RBTC should show up as native token with a logo

Screenshots/Recordings

BOB

BOB-Mobile  ChainList BOB-Mobile  Chain

Rootstock
Rootstock-Mobile  ChainList
Rootstock-Mobile  Mainnet

Rootstock Testnet
Screenshot from 2026-01-09 08-56-33

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds support for BOB and Rootstock visuals across networks and tokens.

  • Import bob.png and rootstock-native.png in image-icons.js; expose BOB, RBTC, and tRBTC token icon keys
  • Extend NETWORK_CHAIN_ID with BOB (0xed88), ROOTSTOCK (0x1e), and ROOTSTOCK_TESTNET (0x1f)
  • Map these chain IDs to images in CustomNetworkImgMapping (bob.png, rootstock.png)

Written by Cursor Bugbot for commit 5335f0c. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gabrieledm
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions github-actions bot added the size-S label Jan 5, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.28%. Comparing base (d672a66) to head (f7e7c29).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24243   +/-   ##
=======================================
  Coverage   79.28%   79.28%           
=======================================
  Files        4065     4066    +1     
  Lines      107173   107258   +85     
  Branches    21830    21859   +29     
=======================================
+ Hits        84971    85041   +70     
- Misses      16248    16262   +14     
- Partials     5954     5955    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeNetworkExpansion, SmokeWalletPlatform
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The changes are purely additive, adding support for two new networks (BOB and Rootstock/Rootstock Testnet):

  1. New image files: bob.png, rootstock.png, rootstock-native.png - static assets
  2. image-icons.js: Added exports for BOB and ROOTSTOCK icons
  3. customNetworks.tsx: Added chain IDs (BOB: 0xed88, ROOTSTOCK: 0x1e, ROOTSTOCK_TESTNET: 0x1f) and their image mappings

These changes:

  • Don't modify any existing functionality
  • Add new constants and mappings to existing data structures
  • Are used by various UI components for network image display (confirmations, balance, trending tokens)

The risk is low because:

  • No existing code paths are modified
  • The new networks won't affect users unless they explicitly add them
  • The changes follow the established pattern for adding network support

Selected tags:

  • SmokeNetworkExpansion: Directly tests new network configurations and network additions
  • SmokeWalletPlatform: Tests core wallet functionality including network switching which may use these new network definitions

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@gabrieledm gabrieledm added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit dc5cb66 Jan 9, 2026
91 checks passed
@gabrieledm gabrieledm deleted the chore/add-bob-and-rootstock-logos branch January 9, 2026 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-S team-network-enablement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants