feat: migrate notification endpoints to v2 #5945
Merged
+1,168
−2,198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this slims down the number of API calls we make, and allows our backend to be the source of truth for notifications.
Prithpal-Sooriya
force-pushed
the
MMASSETS-888/notification-v2-endpoints
branch
from
252aac6 to
15d0996
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
- add API config cache to reduce API calls - ensure push notifications only register active notification acconuts - fetch notifications for active notification accounts - when enabling notifications for a new device, correctly check if we need to register addresses for notifications. - do not clear FCM token as we need it for backend cleanup when re-registering. - make sure our APIs use lowercase addresses (these get hashed on the backend so need to be all same case)
…ification-v2-endpoints
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
Closing as we already have a PR open to resolve this :) |
|
Whoops wrong PR |
now we only fetch notifications for addresses with notifications enabled
…etaMask/core into MMASSETS-888/notification-v2-endpoints
…ification-v2-endpoints
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
…ification-v2-endpoints
oilnam
approved these changes
Jun 18, 2025
oilnam
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Reduces the number of API calls by 25-33% (cut 1/4 - 1/3 endpoints).
Removes complex encryption and decryption logic from UserStorage. This took at least 2s on mobile per request!
Enables us to have our notification backend to be the source of truth. We can now extend notifications easily without as much front-end work.
Test Drive PRs:
References
https://consensyssoftware.atlassian.net/browse/MMASSETS-888
Changelog
Checklist