-
-
Notifications
You must be signed in to change notification settings - Fork 262
feat: add getErc20Balances helper TokenBalancesControllers #5925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32372f2 to
69122ec
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
c93d287 to
2a93861
Compare
sahar-fehri
reviewed
Jun 6, 2025
sahar-fehri
reviewed
Jun 6, 2025
sahar-fehri
reviewed
Jun 6, 2025
sahar-fehri
previously approved these changes
Jun 6, 2025
Prithpal-Sooriya
previously approved these changes
Jun 6, 2025
c6c515c
2a93861 to
c6c515c
Compare
Prithpal-Sooriya
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This change introduces a new
getErc20Balancesservice function within theTokenBalancesController. The goal is to provide a reusable and isolated utility to fetch ERC-20 token balances for a given address and token list.The service is intended to be used internally by the controller or other consumers needing direct access to raw ERC-20 balances, while abstracting away Web3 calls and error handling.
References
Changelog
@metamask/assets-controllersUPDATE: Created getErc20Balances function within TokenBalancesController to support fetching ERC-20 token balances for a given address and token list. This modular service simplifies balance retrieval logic and can be reused across different parts of the controller.
Checklist