Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Jun 4, 2025

Explanation

I missed this when introducing the KeyringRequest.origin feature.

The main problem is that this controller is dispatching "raw Snap request", thus, preventing any type-checking when doing keyring API updades.

By using KeyringClient this should prevent this kind of problems in the future and it aligns well on how other controllers interact with the keyring API too!

References

N/A

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly marked this pull request as ready for review June 4, 2025 12:22
@ccharly ccharly requested review from a team as code owners June 4, 2025 12:22
@ccharly
Copy link
Contributor Author

ccharly commented Jun 4, 2025

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "30.0.0-preview-d2bf8ff",
  "@metamask-previews/address-book-controller": "6.1.0-preview-d2bf8ff",
  "@metamask-previews/announcement-controller": "7.0.3-preview-d2bf8ff",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-d2bf8ff",
  "@metamask-previews/approval-controller": "7.1.3-preview-d2bf8ff",
  "@metamask-previews/assets-controllers": "68.0.0-preview-d2bf8ff",
  "@metamask-previews/base-controller": "8.0.1-preview-d2bf8ff",
  "@metamask-previews/bridge-controller": "32.1.0-preview-d2bf8ff",
  "@metamask-previews/bridge-status-controller": "29.1.0-preview-d2bf8ff",
  "@metamask-previews/build-utils": "3.0.3-preview-d2bf8ff",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-d2bf8ff",
  "@metamask-previews/composable-controller": "11.0.0-preview-d2bf8ff",
  "@metamask-previews/controller-utils": "11.9.0-preview-d2bf8ff",
  "@metamask-previews/delegation-controller": "0.4.0-preview-d2bf8ff",
  "@metamask-previews/earn-controller": "1.0.0-preview-d2bf8ff",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-d2bf8ff",
  "@metamask-previews/ens-controller": "16.0.0-preview-d2bf8ff",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-d2bf8ff",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-d2bf8ff",
  "@metamask-previews/foundryup": "1.0.0-preview-d2bf8ff",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-d2bf8ff",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-d2bf8ff",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-d2bf8ff",
  "@metamask-previews/keyring-controller": "22.0.1-preview-d2bf8ff",
  "@metamask-previews/logging-controller": "6.0.4-preview-d2bf8ff",
  "@metamask-previews/message-manager": "12.0.1-preview-d2bf8ff",
  "@metamask-previews/multichain": "4.1.0-preview-d2bf8ff",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-d2bf8ff",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-d2bf8ff",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-d2bf8ff",
  "@metamask-previews/name-controller": "8.0.3-preview-d2bf8ff",
  "@metamask-previews/network-controller": "23.5.1-preview-d2bf8ff",
  "@metamask-previews/notification-services-controller": "10.0.0-preview-d2bf8ff",
  "@metamask-previews/permission-controller": "11.0.6-preview-d2bf8ff",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-d2bf8ff",
  "@metamask-previews/phishing-controller": "12.5.0-preview-d2bf8ff",
  "@metamask-previews/polling-controller": "13.0.0-preview-d2bf8ff",
  "@metamask-previews/preferences-controller": "18.1.0-preview-d2bf8ff",
  "@metamask-previews/profile-sync-controller": "17.0.0-preview-d2bf8ff",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-d2bf8ff",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-d2bf8ff",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-d2bf8ff",
  "@metamask-previews/sample-controllers": "0.1.0-preview-d2bf8ff",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-d2bf8ff",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-d2bf8ff",
  "@metamask-previews/signature-controller": "30.0.0-preview-d2bf8ff",
  "@metamask-previews/token-search-discovery-controller": "3.2.0-preview-d2bf8ff",
  "@metamask-previews/transaction-controller": "57.0.0-preview-d2bf8ff",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-d2bf8ff"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants