reduce mentra live flash time and buildscript fixes #1767
Conversation
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🕶️ ASG Client Build✅ Ready to test! (commit 🔀 Test Locallygh pr checkout 1767 |
Added silent parameter to requestPhoto override methods to match the updated SGCManager abstract method signature. 🤖 Generated with [Claude Code](https://claude.ai/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| String size = data.optString("size", "medium"); | ||
| String compress = data.optString("compress", "none"); // Default to none (no compression) | ||
| boolean enableLed = data.optBoolean("enable_led", true); // Default true for phone commands | ||
| // silent: true = no sound/LED, false (default) = normal behavior with sound/LED | ||
| boolean silent = data.optBoolean("silent", false); | ||
| boolean enableLed = !silent; // Convert to internal enableLed (inverted logic) |
There was a problem hiding this comment.
The take_photo handler now only reads a new silent flag and sets enableLed to !silent, dropping the previous enable_led field that callers used to disable shutter sound/LED. Any client still sending {"enable_led": false} (the documented contract before this change) will now hit the default silent=false, so the privacy indicators are forced on again. This is a backward-incompatible regression for photo capture (and the same pattern was added to the video and RTMP handlers), preventing callers from suppressing sound/LED without switching to the new field.
Useful? React with 👍 / 👎.
- Check if release keystore exists before using it, fall back to debug keystore - Add clear console output showing which signing config is being used - Fix localKeystore path (../../credentials/ from android/app/) This allows developers without production signing keys to build and test locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Deploying mentra-live-ota-site with
|
| Latest commit: |
e8e61ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b32ee8c.mentra-live-ota-site.pages.dev |
| Branch Preview URL: | https://reduce-mentra-live-flash-tim.mentra-live-ota-site.pages.dev |
Deploying mentra-store-dev with
|
| Latest commit: |
e8e61ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db18515f.augmentos-appstore-2.pages.dev |
| Branch Preview URL: | https://reduce-mentra-live-flash-tim.augmentos-appstore-2.pages.dev |
Deploying dev-augmentos-console with
|
| Latest commit: |
e8e61ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ed79c2dc.dev-augmentos-console.pages.dev |
| Branch Preview URL: | https://reduce-mentra-live-flash-tim.dev-augmentos-console.pages.dev |
Deploying prod-augmentos-account with
|
| Latest commit: |
e8e61ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a0e0e207.augmentos-e84.pages.dev |
| Branch Preview URL: | https://reduce-mentra-live-flash-tim.augmentos-e84.pages.dev |
No description provided.