Gallery n camera improvements #1744
Conversation
…capture. Updated AE wait time to 2 seconds and introduced a feature flag for immediate capture on convergence.
…drag animation handling in GalleryScreen
📋 PR Review Helper📱 Mobile App Build✅ Ready to test! (commit 🔀 Test Locallygh pr checkout 1744 |
Deploying mentra-live-ota-site with
|
| Latest commit: |
d769443
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://57ef95ec.mentra-live-ota-site.pages.dev |
| Branch Preview URL: | https://gallery-n-camera-improvement.mentra-live-ota-site.pages.dev |
Deploying mentra-store-dev with
|
| Latest commit: |
d5f4b17
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82eace69.augmentos-appstore-2.pages.dev |
| Branch Preview URL: | https://gallery-n-camera-improvement.augmentos-appstore-2.pages.dev |
Deploying dev-augmentos-console with
|
| Latest commit: |
d5f4b17
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://29c43585.dev-augmentos-console.pages.dev |
| Branch Preview URL: | https://gallery-n-camera-improvement.dev-augmentos-console.pages.dev |
Deploying prod-augmentos-account with
|
| Latest commit: |
d5f4b17
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3fa5d975.augmentos-e84.pages.dev |
| Branch Preview URL: | https://gallery-n-camera-improvement.augmentos-e84.pages.dev |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {/* Fallback to modal viewer for videos or when source frame not measured */} | ||
| {selectedPhoto && !transitionState.activePhoto && ( | ||
| <MediaViewer | ||
| visible={true} | ||
| photo={selectedPhoto} |
There was a problem hiding this comment.
Tapping a measured thumbnail sets transitionState.activePhoto in handlePhotoPress, but the MediaViewer is only rendered when selectedPhoto && !transitionState.activePhoto. Because the transition path never sets selectedPhoto, this condition is never satisfied after the new floating transition runs, so users only see the static FloatingImageLayer overlay with no zoom/share controls and downloaded videos never play. The modal viewer is only reachable via the fallback where no source frame exists.
Useful? React with 👍 / 👎.
|
Issue 1: Photos appear to low when selected. They should be centered vertically. Issue 2: Videos don't load. I just see a black screen. |
|
Syncing works but photos are still too low, and scrolling left/right is laggy and only works for videos; not pictures. |
- Introduced AwesomeGalleryViewer for seamless image and video viewing with smooth swiping. - Added test gallery data for development, including images and videos for testing the MediaViewer component. - Updated GalleryScreen to conditionally include test data in development mode. - Removed legacy ImageViewer component and simplified MediaViewer to utilize AwesomeGalleryViewer. - Updated package.json to include react-native-awesome-gallery dependency.
- Updated error message overlay and play button positioning for clarity. - Enhanced ImageItem component with themed styles for better visual consistency. - Adjusted layout of image container for improved visual balance.
… error messaging - Updated error overlay to be more descriptive. - Refactored video controls into a unified bottom bar for better usability. - Adjusted styles for play button and seek bar for improved visual consistency. - Minor code clean-up in GalleryScreen for better readability.
…d loading indicators - Added buffering state management and visual indicators for video loading. - Implemented thumbnail display while videos load for better user experience. - Refactored video auto-play logic to prevent restarting after completion. - Improved error handling and logging for video and image loading processes. - Adjusted styles for tap areas and overlays to enhance usability.
…ces with underscores
- Replaced the import of useAppTheme from utils with the one from ThemeContext for better consistency and maintainability.
|
[] needs some small bottom padding for old android navbar when watching a video |
- Updated VideoPlayerItem to restart video playback from the beginning when returning from inactive state. - Improved GalleryScreen by memoizing functions to optimize performance and prevent unnecessary re-renders. - Adjusted layout properties for better responsiveness and user experience. - Commented out unused notification code in gallerySyncNotifications for clarity and future reference.
…ience - Added user pause tracking to respect manual playback state. - Enhanced auto-play logic to prevent playback when user has manually paused. - Updated control bar interactions to improve responsiveness and prevent unintended toggling of controls. - Added console logs for better debugging and user feedback during playback actions.
No description provided.