fix(closet_llm): replace non-ASCII symbols in progress output (#1034)#1100
Open
arnoldwender wants to merge 1 commit intoMemPalace:developfrom
Open
fix(closet_llm): replace non-ASCII symbols in progress output (#1034)#1100arnoldwender wants to merge 1 commit intoMemPalace:developfrom
arnoldwender wants to merge 1 commit intoMemPalace:developfrom
Conversation
…ace#1034) GBK consoles (Windows PowerShell/CMD default) cannot encode U+2713 (✓), U+2717 (✗), and U+2014 (—). The same class of UnicodeEncodeError fixed in miner.py via MemPalace#681 affects closet_llm.py and cli.py. Replace with ASCII equivalents: [OK], [FAIL], [!], and hyphen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and Why
closet_llm.pyprints✓,✗, and—(U+2713, U+2717, U+2014) duringmempalace closets regen. These characters cannot be encoded in GBK (Windows PowerShell/CMD default), causingUnicodeEncodeErroron the same code path fixed inminer.pyvia #681.cli.pyhas the same problem on thesweeperror path (✗).Root Cause
closet_llm.py:244——in dry-run bannercloset_llm.py:266—✗+—in LLM-failed messagecloset_llm.py:303—✓+—in success messagecli.py:187—✗in sweep error messageChange Summary
Replace non-ASCII symbols with ASCII equivalents:
[OK],[FAIL],[!], and-.Test Plan
ruff checkcleanCloses #1034