make hotend PIDTEMP optional in PID_autotune#28367
Open
ellensp wants to merge 1 commit intoMarlinFirmware:bugfix-2.1.xfrom
Open
make hotend PIDTEMP optional in PID_autotune#28367ellensp wants to merge 1 commit intoMarlinFirmware:bugfix-2.1.xfrom
ellensp wants to merge 1 commit intoMarlinFirmware:bugfix-2.1.xfrom
Conversation
Contributor
Author
|
Please check thoroughly, It seems correct but it's after midnight and my brain has turned into a pumpkin |
1bc0732 to
72c7874
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Presently
void Temperature::PID_autotune(const celsius_t target, const heater_id_t heater_id, const int8_t ncycles, const bool set_result/*=false*/)assume a hotend exists and has pid values if anything has pid enabled.If you set the following in Configuration.h
#define TEMP_SENSOR_0 0
#define PIDTEMPBED
PIDTEMP is auto undefined as it should be but PID_autotune assumes otherwise
resulting in errors:
Requirements
#define TEMP_SENSOR_0 0
#define PIDTEMPBED
Benefits
Builds as expceted