Add typing annotations to svg_mobject.py #4318
Conversation
| @@ -509,11 +510,11 @@ def init_points(self) -> None: | |||
|
|
|||
| def handle_commands(self) -> None: | |||
| all_points: list[np.ndarray] = [] | |||
| last_move = None | |||
| last_move: np.ndarray = None | |||
There was a problem hiding this comment.
The np.ndarray type seems to work here. But is there any better? I don't think it should be Point3DLike.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -121,10 +122,10 @@ | |||
| self.color = color | |||
| self.opacity = opacity | |||
| self.fill_color = fill_color | |||
| self.fill_opacity = fill_opacity | |||
| self.fill_opacity = fill_opacity # type: ignore[assignment] | |||
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning
| self.stroke_color = stroke_color | ||
| self.stroke_opacity = stroke_opacity | ||
| self.stroke_width = stroke_width | ||
| self.stroke_opacity = stroke_opacity # type: ignore[assignment] |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning
| @@ -121,10 +122,10 @@ def __init__( | |||
| self.color = color | |||
| self.opacity = opacity | |||
| self.fill_color = fill_color | |||
| self.fill_opacity = fill_opacity | |||
| self.fill_opacity = fill_opacity # type: ignore[assignment] | |||
There was a problem hiding this comment.
The type annotations for the SVGMobject allows this value to be None, which is not compatible with the superclass VMobject. It seems to be fixed using some kind of default SVG value magic a few lines later.
| self.stroke_opacity = stroke_opacity # type: ignore[assignment] | ||
| self.stroke_width = stroke_width # type: ignore[assignment] |
There was a problem hiding this comment.
Same as above.
| @@ -435,7 +436,7 @@ def text_to_mobject(text: se.Text): | |||
| The parsed SVG text. | |||
| """ | |||
| logger.warning(f"Unsupported element type: {type(text)}") | |||
| return | |||
| return # type: ignore[return-value] | |||
There was a problem hiding this comment.
Can we get rid of this mypy ignore statement?
| self.stroke_opacity = stroke_opacity | ||
| self.stroke_width = stroke_width | ||
| self.stroke_opacity = stroke_opacity # type: ignore[assignment] | ||
| self.stroke_width = stroke_width # type: ignore[assignment] |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning
Overview: What does this pull request change?
Reviewer Checklist