Added ability to save original Gemfile.lock#22
Added ability to save original Gemfile.lock#22d-lebed wants to merge 2 commits intoManageIQ:masterfrom
Conversation
|
This is a cool idea. We had a similar problem recently with building ManageIQ where I accidentally committed my overrides to the lock. @bdunne What do you think? |
|
@d-lebed Can you add some specs for these cases (particularly for the "not able to be resolved" case, which is pretty interesting)? |
|
@Fryguy I'm sorry for the delay. Have some work to do. I'll continue working on this one once I'll have some free time. |
|
No problem 😊 |
|
I don't use gem overwrites, but it can be done also by my solution, by pointing on local gem path source. To deliver actually described feature you can use following method, without installing bundler-inject. Add new GemfileDev file with content: then call (or set in shell) ENV variable: It will create separate GemfileDev.lock and you should add those GemfileDev* to git ignore. Actually I don't see bundler-inject so helpful if Gemfile.lock will change, so I like your idea @d-lebed PS. Greetings to juliancheal ! I cannot mention you guy @ github :D |
|
bundler 2.4.7 has option |
I understand that this probably will never be merged to master, so it's more like "feature request"
It also requires refinements, proper tests, etc… I'll work on that if you'll say that this feature may be merged once it's ready and stable.
The main idea here is to keep
Gemfile.lock"pristine" when working using gem overrides. Ifbundler_inject.enable_pristineoption set to true this creates anotherGemfile.lock.localnear original one and uses it by default. So you don't need to remove overrides each time you want to commit changes.What do you think?