[tests] Review and refactor translation tests #3792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristjanESPERANTO
force-pushed
the
loadJSON
branch
from
443b175 to
caf275e
Compare
KristjanESPERANTO
changed the title
loadJSON function in translator.jsloadJSON function in translator.js
KristjanESPERANTO
force-pushed
the
loadJSON
branch
from
5934da1 to
2c87833
Compare
KristjanESPERANTO
force-pushed
the
loadJSON
branch
from
2c87833 to
bd4b17a
Compare
rejas
pushed a commit
that referenced
this pull request
Jun 9, 2025
…s" (#3809) While working on the translations (in #3792 and #3794) I realised that the e2e "Same keys" tests were not working entirely. There was also a TODO entry for this in the test, as well as a try-catch-block workaround. I therefore fixed and refactored it. I also sorted the translations in `translations/translations.js`, so that the test outputs are alphabetically.
KristjanESPERANTO
force-pushed
the
loadJSON
branch
from
bd4b17a to
ecd87c4
Compare
KristjanESPERANTO
changed the title
loadJSON function in translator.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored the translations tests, they should now be clearer and easier to understand. There should be no functional impact.
I have discarded the original approach of also replacing
XMLHttpRequestwithfetchin the filejs/translator.js. I had managed to get it to work functionally, but I couldn't get the tests to work.