kappa-rho-conserv decision tree#1449
Draft
handwerkerd wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
===========================================
- Coverage 90.41% 62.34% -28.08%
===========================================
Files 30 30
Lines 4906 4903 -3
Branches 901 898 -3
===========================================
- Hits 4436 3057 -1379
- Misses 316 1695 +1379
+ Partials 154 151 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've discussed with a bunch of people the idea of making a conservative decision tree that will not remove all noise, but is very unlikely to remove signal someone cares about.
At first glance, this is sometimes retaining the high variance linear drift component, so maybe we might want this to be a bit more aggressive. Still, if the goal is to be conservative, then that's not necessary a problem. I'm releasing this as a draft so that people can test this on their data to see if it performs as expected.
Changes proposed in this pull request:
tedana/resources/decision_trees/kapparho_conserv.jsonminimaldecision tree expect I got rid of all other metrics besides kappa & rho>0.95& kappa elbowand<1.05* rho elbow.tedana/selection/component_selector.pyis also updated so that this decision tree would be one of the default options.