Skip to content

fix: optimistic UI update for album pin/unpin#4329

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/fix-pinning-albums-delay
Draft

fix: optimistic UI update for album pin/unpin#4329
Copilot wants to merge 3 commits intomasterfrom
copilot/fix-pinning-albums-delay

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026 •
edited
Loading

  • Revert optimistic update in Albums.vue togglePin() — call refresh() after API response (fixes deduplicate_pinned_albums incompatibility)
  • Revert optimistic update in AlbumPanel.vue togglePin() — call emits("refresh") after API response
  • Deduplicate selectableAlbums getter in AlbumsState.ts by ID — fixes "2 albums selected" context menu when deduplicate_pinned_albums=false
  • TypeScript check passes

Copilot AI linked an issue Apr 29, 2026 that may be closed by this pull request
Pinning albums is delayed #3878
Open
3 tasks
Copilot AI changed the title [WIP] Fix delay in pinning albums visibility fix: optimistic UI update for album pin/unpin Apr 29, 2026
Copilot AI requested a review from ildyria April 29, 2026 17:30
@ildyria
fix: revert optimistic pin update; deduplicate selectableAlbums when …
d8a582e 
…deduplicate_pinned_albums=false

Agent-Logs-Url: https://github.com/LycheeOrg/Lychee/sessions/27a1cc58-3934-4a7a-85f2-10c7291ee139

Co-authored-by: ildyria <627094+ildyria@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ildyria ildyria Awaiting requested review from ildyria

At least 1 approving review is required to merge this pull request.

Assignees

@ildyria ildyria

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pinning albums is delayed

2 participants

@ildyria