Sohyungpark #31
Open
Sohyungpark #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@sohyungpark 3주차가 정상적으로 제출되지 않았습니다!. |
iubns
reviewed
May 20, 2025
박소형/week4/src/components/mainApp.js
Outdated
Comment on lines
+11
to
+20
Member
There was a problem hiding this comment.
어.. 어떠한 페이지를 보여줄지 상태로 관리하여 특정 컴포넌트를 렌더링 하는 것이 아닌
next/nagivation을 사용하여 push로 페이지 이동해주세요.
박소형/week4/src/components/ChatApp.js
Outdated
Member
There was a problem hiding this comment.
css 파일을 그대로 불러오면 class-name 충돌이 발생할 수 있습니다.
module로 변경해주세요
Member
There was a problem hiding this comment.
또한 style 파일을 아에 다른 폴더에 넣는 것이 아닌 component와 style 파일을 하나의 폴더로 묶어주세요
박소형/week4/src/components/ChatApp.js
Outdated
Comment on lines
15
to
+18
Member
There was a problem hiding this comment.
처음에 초기화 할땐 class가 없는데 새로 메시지 추가할땐 class가 생기네요.
일관성 있게 코드를 작성해주시면 좋을거 같습니다.
Comment on lines
+8
to
9
Member
There was a problem hiding this comment.
이거 주소를 그냥 /profile.jpeg로 하면 작동이 안되나요?
박소형/week4/src/components/ChatList.js
Outdated
Member
There was a problem hiding this comment.
컴포넌트마다 style 파일을 분리한 것은 좋을거 같습니다.
박소형/week4/src/components/EditBox.js
Outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4주차 과제입니다.