Bugfix: ignore index + macro combination in classification metrics #2443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@SkafteNicki, what is missing here to make it land? 🐿️ |
|
Is this still happening? |
|
Any chance that this will be worked on in the near future? |
Collaborator
cc: @SkafteNicki |
Borda
force-pushed
the
master
branch
2 times, most recently
from
d0a5568 to
9fc79ae
Compare
Collaborator
do you want to take it over and reopen @SkafteNicki commits as part of your/new PR so you will share contribution? 🦩 |
Borda
force-pushed
the
master
branch
2 times, most recently
from
4b07b79 to
9f4a001
Compare
Collaborator
|
@DimitrisMantas @JeroenMandersloot are you interested in taking this over and finishing it? 🦩 |
Collaborator
|
@rittik9, would you be interested in finishing this one? 🐰 |
Collaborator
|
Yeah sure I'll give it a try |
Collaborator
|
@SkafteNicki let's finish it or close it? 🐿️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2441
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2443.org.readthedocs.build/en/2443/