-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix double iteration bug when resumed from a checkpoint. #20775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sudiptob2
wants to merge
5
commits into
Lightning-AI:master
Choose a base branch
from
sudiptob2:fix/19427/double-iter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Apr 29, 2025
Borda
reviewed
Apr 30, 2025
tests/tests_pytorch/loops/test_double_iter_in_iterable_dataset.py
Outdated
Show resolved
Hide resolved
@Borda Thanks for the review! Let me know if there's anything you'd like me to change. Otherwise, can we go ahead and merge this? |
Borda
reviewed
May 12, 2025
Comment on lines
238
to
241
# Only call iter() if: | ||
# 1. Not restarting AND | ||
# 2. Not resuming from checkpoint (not _is_resuming) AND | ||
# 3. Past first epoch (current_epoch > 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# Only call iter() if: | |
# 1. Not restarting AND | |
# 2. Not resuming from checkpoint (not _is_resuming) AND | |
# 3. Past first epoch (current_epoch > 0) | |
# Only call `iter()` if all following cases: | |
# 1. Not restarting | |
# 2. Not resuming from checkpoint (not _is_resuming) | |
# 3. Past first epoch (current_epoch > 0) |
Borda
reviewed
May 12, 2025
tests/tests_pytorch/loops/test_double_iter_in_iterable_dataset.py
Outdated
Show resolved
Hide resolved
5c9a0fd
to
eb3a763
Compare
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
e451080
to
130102c
Compare
Hey, @Borda just wondering if anything is blocking this PR from merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the double
iter()
bug discussed in #19427Fixes #19427
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20775.org.readthedocs.build/en/20775/