Skip to content

adding logger args #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 27, 2025
Merged

Conversation

ysjprojects
Copy link
Contributor

@ysjprojects ysjprojects commented Mar 18, 2025

Addresses #1909.

More fine-grained logging args: supports e.g wandb args specifying run_name and group_name for now.

New LoggerArgs as it fits neither TrainArgs nor EvalArgs. We can expand on this in the future.

@Borda
Copy link
Member

Borda commented Apr 15, 2025

wandb is not the only one or default logger so we shall not name it with generic LogArgs

@Borda Borda marked this pull request as draft April 15, 2025 10:25
@ysjprojects ysjprojects marked this pull request as ready for review May 20, 2025 20:22
@ysjprojects ysjprojects requested a review from Borda as a code owner May 20, 2025 20:22
@ysjprojects
Copy link
Contributor Author

Removed references to wandb in LogArgs.

Also, is there a reason why we don't pass the name argument to csv and tensorboard loggers?

def choose_logger(
    logger_name: Literal["csv", "tensorboard", "wandb", "mlflow"],
    out_dir: Path,
    name: str,
    log_interval: int = 1,
    log_args: Optional[Dict] = None,
    resume: Optional[bool] = None,
    **kwargs: Any,
):
    if logger_name == "csv":
        return CSVLogger(root_dir=(out_dir / "logs"), name="csv", flush_logs_every_n_steps=log_interval, **kwargs)
    if logger_name == "tensorboard":
        return TensorBoardLogger(root_dir=(out_dir / "logs"), name="tensorboard", **kwargs)

@Borda

@Borda Borda changed the title wandb logger args adding logger args May 27, 2025
@Borda Borda merged commit e6740f5 into Lightning-AI:main May 27, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants