fix(docker): Fix git submodules not properly handling through#62
Closed
fix(docker): Fix git submodules not properly handling through#62
Conversation
🔨 Build Results✅ Backend Build: Passed 🎉 All builds completed successfully! |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Collaborator
Author
|
I'd close this PR as it is no longer applicable for current structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fix of #60
tldr: This fix copies .git and .gitmodules to the prod environment (although it's not the best option but it's part of the LifeForge package manager mechanism so we have to keep it)
Also applied proper scanning mechanism for pocketbase by checking whether the pocketbase is really present or not (using shell command)
Note this is just temporary fix as some inconsistencies still occurs. However, schema synchronisation is now a MUST. The project itself is updating too fast.
This pull request introduces several improvements to Docker and development workflows, especially around submodule management and PocketBase server startup. The main changes ensure that git submodules are handled correctly in Docker builds, and that the PocketBase binary is automatically downloaded if missing, improving developer experience and deployment reliability.
Docker and Git Submodule Handling:
apps/walletsubmodule to.gitmodules, enabling the project to include and manage the newwalletapp as a submodule..gitand.gitmodulesfiles into the container, allowing git commands (such as submodule initialization) to work inside Docker. [1] [2]gitin the Docker image to support operations that require git at runtime..dockerignoreto stop ignoring the.gitdirectory, ensuring it is available in Docker builds where needed.PocketBase Server Improvements: