refactor(forgeCLI): improve logging and process validation for PocketBase#61
Merged
melvinchia3636 merged 3 commits intomainfrom Jan 1, 2026
Merged
refactor(forgeCLI): improve logging and process validation for PocketBase#61melvinchia3636 merged 3 commits intomainfrom
melvinchia3636 merged 3 commits intomainfrom
Conversation
🔨 Build Results✅ Backend Build: Passed 🎉 All builds completed successfully! |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
melvinchia3636
approved these changes
Jan 1, 2026
Member
melvinchia3636
left a comment
melvinchia3636
left a comment
There was a problem hiding this comment.
LGTM on behalf of lukas
Collaborator
Author
|
|
melvinchia3636
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the fix of #60
tidr: This fix implements better pocketbase process detection using ps instead of pgrep (due to issues in Linux that causing "weird spawning" pocketbase process out from nowhere.
This pull request improves the reliability and clarity of the PocketBase server management logic in the Forge CLI. The main focus is on making the detection of running PocketBase processes more robust and providing clearer messaging to users during database setup.
Improvements to PocketBase process detection:
isValidPocketbaseProcessto verify that a detected PID is actually a running PocketBase process by checking the command name, reducing the risk of false positives.checkRunningPBInstancesto use the new validation logic, handle multiple PIDs, and improve error messages by listing all detected PocketBase process IDs.User messaging enhancements:
initializeDatabaseHandlerto inform users in a single step that setup is complete and how to start the PocketBase server.