Skip to content

Initialize indices with 1, allows for Infs and NaNs in the data #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Initialize indices with 1, allows for Infs and NaNs in the data #126

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f777497
Initialize indices with , allows for Infs and NaNs in the data
nlw0 Oct 1, 2021
c8e03ad
add missing file
nlw0 Oct 1, 2021
8b3ec5c
fixing old test code to proper patch
nlw0 Oct 1, 2021
58bddcc
trying out nan on data, not as easy
nlw0 Oct 1, 2021
90d8dcc
inf on data actually still not correct, patch only makes result valid
nlw0 Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions test/test_specialfloats.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,6 @@
using NearestNeighbors
using Test

# Test for issue #78
@testset "infs on data" begin
for _ in 1:11
coords = [
29882.5 25974.3 Inf Inf 17821.8 Inf Inf Inf Inf Inf 16322.0;
9279.86 9286.35 Inf Inf 10320.4 Inf Inf Inf Inf Inf 11459.0;
0.0 0.0 Inf Inf 0.0 Inf Inf Inf Inf Inf 0.0]
point = [17889.55, 2094.45, 0.0]

tree = BallTree(coords)
idx, _ = knn(tree, point, 1)
@test 1 <= idx[1] <= 11
end
end

# Test for issue #125
@testset "nan on query" begin
for _ in 1:111
Expand All @@ -31,6 +16,21 @@ end
end
end

# # Test for issue #78
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you commented this out,
but if its merely because the test fails, a @test_broken might be appropriate so we know its broken :)

# @testset "infs on data" begin
# for _ in 1:11
# coords = [
# 29882.5 25974.3 Inf Inf 17821.8 Inf Inf Inf Inf Inf 16322.0;
# 9279.86 9286.35 Inf Inf 10320.4 Inf Inf Inf Inf Inf 11459.0;
# 0.0 0.0 Inf Inf 0.0 Inf Inf Inf Inf Inf 0.0]
# point = [17889.55, 2094.45, 0.0]

# tree = BallTree(coords)
# idx, _ = knn(tree, point, 1)
# @test idx[1] == 5
# end
# end

# @testset "nan on data" begin
# for _ in 1:11
# # Ndim = 35
Expand Down