Syntax highlighting for KCL #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closes #6
adamchalmers
force-pushed
the
achalmers/syntax-highlighting
branch
from
cfdea57 to
c3c654b
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| hljs.registerLanguage("kcl", function () { | ||
| "use strict"; | ||
| return function (e) { | ||
| const KEYWORDS = "if impl let if else for while return break continue fn let mut as loop nil and or not var const import export type interface new self from record struct object" |
Contributor
There was a problem hiding this comment.
The keyword if appears twice in the KEYWORDS constant. This duplication should be removed to maintain a clean and accurate list of language keywords.
Suggested change
| const KEYWORDS = "if impl let if else for while return break continue fn let mut as loop nil and or not var const import export type interface new self from record struct object" | |
| const KEYWORDS = "if impl let else for while return break continue fn mut as loop nil and or not var const import export type interface new self from record struct object" |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
It's not great, but it's better than nothing.