Skip to content

Conversation

@adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Nov 21, 2025

Instead of relying on the order constraints come in, give each constraint an ID, and track it throughout execution.

This is going to be helpful for #147, where the order of each constraint in the constraint vec given by the user may be reordered, because the order they're in might not correspond to their prioritized order.

This should not have any effect on the public API.

…aint an ID, and track it throughout execution.

This is going to be helpful for #147, where the order of each constraint in the constraint vec given by the user may be reordered, because the order they're in might not correspond to their prioritized order.

This should not have any effect on the public API.
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #150 will not alter performance

Comparing achalmers/entries (98eb0fa) with main (a7e931b)

Summary

✅ 13 untouched

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.02%. Comparing base (a7e931b) to head (98eb0fa).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kcl-ezpz/src/constraints.rs 0.00% 3 Missing ⚠️
kcl-ezpz/src/warnings.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   91.06%   91.02%   -0.04%     
==========================================
  Files          18       18              
  Lines        4533     4548      +15     
==========================================
+ Hits         4128     4140      +12     
- Misses        405      408       +3     
Flag Coverage Δ
unittests 91.02% <90.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamchalmers adamchalmers merged commit b12d068 into main Nov 21, 2025
13 checks passed
@adamchalmers adamchalmers deleted the achalmers/entries branch November 21, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants