Skip to content

Conversation

@gpx1000
Copy link
Collaborator

@gpx1000 gpx1000 commented Jan 10, 2026

Optimize shader build system to avoid unnecessary rebuilds and source tree modifications

Use copy_if_different instead of copy to prevent timestamp churn on checked-in shader binaries. Change MAIN_DEPENDENCY to DEPENDS and add VERBATIM to custom commands for HLSL, Slang, GLSL, and SPIR-V assembly shader compilation.

This is part of my make the build system better work. This fixes the issue we have called out for it so I'm breaking this change out of the overall change that I'm working on for cmake to improve our build speed on all platforms.

Fixes #1248

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

… tree modifications

Use `copy_if_different` instead of `copy` to prevent timestamp churn on checked-in shader binaries. Change `MAIN_DEPENDENCY` to `DEPENDS` and add `VERBATIM` to custom commands for HLSL, Slang, GLSL, and SPIR-V assembly shader compilation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HLSL shaders are compiled on every build

2 participants