Skip to content

Conversation

@gpx1000
Copy link
Collaborator

@gpx1000 gpx1000 commented Jan 9, 2026

Filter unsupported present modes and fix UBSan warnings in type casting

  • Add no_sanitize attributes to suppress false-positive UBSan warnings for intentional C/C++ binding interop
  • Implement custom DeviceDeleter to properly delete correct dynamic type (DeviceC vs DeviceCpp)
  • Only create HPPStats when RenderContext is available to avoid null pointer issues in low-level samples

While working on this, I discovered that there's a VVL error in swapchain_recreation. This fixes the VVL warning:

  • Remove FIFO_LATEST_READY present modes when corresponding extensions/features are not enabled in swapchain_recreation sample

Description

Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines

Fixes #

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

- Remove FIFO_LATEST_READY present modes when corresponding extensions/features are not enabled in swapchain_recreation sample
- Add no_sanitize attributes to suppress false-positive UBSan warnings for intentional C/C++ binding interop
- Implement custom DeviceDeleter to properly delete correct dynamic type (DeviceC vs DeviceCpp)
- Only create HPPStats when RenderContext is available to avoid null pointer issues in low-level samples
- Standardize indentation for preprocessor directives and function declarations
- Align function return types and names across multiple files
- Correct whitespace in conditional compilation blocks
- Remove extra spaces in variable declarations
- Update copyright end year from 2025 to 2026 across framework and sample files
- Affected files include swapchain_recreation sample, command pool base, vulkan resource, HPP queue, and vulkan sample headers
@gpx1000 gpx1000 linked an issue Jan 9, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type confusion error when running under UBSan

2 participants