Transcoded version of api sample hello_triangle_1_3 based on Vulkan-Hpp

[asuessenbach]

Description

Introduces a new Vulkan-Hpp-based sample, which is a transcoded version of the api sample hello_triangle_1_3.

Build tested on Win10 with VS2022. Run tested on Win10 with NVidia GPU.

Fixes #1312

General Checklist:

Please ensure the following points are checked:

• My code follows the coding style
• I have reviewed file licenses
• I have commented any added functions (in line with Doxygen)
• I have commented any code that could be hard to understand
• My changes do not add any new compiler warnings
• My changes do not add any new validation layer errors or warnings
• I have used existing framework/helper functions where possible
• My changes do not add any regressions
• I have tested every sample to ensure everything runs correctly
• This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

• I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
• My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

• I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

• I have tested the sample on at least one compliant Vulkan implementation
• If the sample is vendor-specific, I have tagged it appropriately
• I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
• Any dependent assets have been merged and published in downstream modules
• For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
• For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
• For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

[SaschaWillems]

LGTM. Sample works fine for me on Win11 + RTX 4070.

Thank you very much 👍🏻

[gary-sweet]

For some reason this sample doesn't work for me. I get:

[error] Error Message: Failed to create window surface.
[error] Failed when running application Vulkan 1.3 HPP Hello Triangle

hello_triangle_1_3 works fine, as does hpp_hello_triangle. Any ideas?

[asuessenbach]

Any ideas?

Nope.

That error is probably thrown in hpp_hello_triangle_1_3.cpp, line 131 (after rebasing).
That is, the function options.window->create_surface failed to create the surface.
What platform are you running? Is it GlfwWindow::create_surface that's called or HeadlessWindow::create_surface?
What's the result of that function call?

[gary-sweet]

That error is probably thrown in hpp_hello_triangle_1_3.cpp, line 131 (after rebasing). That is, the function options.window->create_surface failed to create the surface. What platform are you running? Is it GlfwWindow::create_surface that's called or HeadlessWindow::create_surface? What's the result of that function call?

So it looks as though a NULL context.gpu is being passed into create_surface(). Given that init_device() hasn't been called yet, I guess that isn't a surprise, but doesn't seem right?

My platform will end up in the DirectWindow class.

[asuessenbach]

My platform will end up in the DirectWindow class.

Yeah, and I think, that's the only platform where this issue pops up.
Hopefully fixed it with my latest change.

[gary-sweet]

Sadly this is still crashing for me, but in a different place now.
I'll need to do some debugging later to figure out what's going on.

[gary-sweet]

Sadly this is still crashing for me, but in a different place now. I'll need to do some debugging later to figure out what's going on.

It's looking like the extension functions haven't been setup yet when find_display_candidates() is called.

[gary-sweet]

Looks good now, thanks

[marty-johnson59]

3 approvals - merging