Skip to content

Remove mise.toml and update 'engines' in package.json#1239

Merged
kevinb-khan merged 2 commits intomainfrom
fei-7566.2
Apr 9, 2026
Merged

Remove mise.toml and update 'engines' in package.json#1239
kevinb-khan merged 2 commits intomainfrom
fei-7566.2

Conversation

@kevinb-khan
Copy link
Copy Markdown
Contributor

Summary:

Now that the global mise config is specifying Node 24.13 we no longer need the repo-specific mise.toml files. This PR also updates the 'engines' field in package.json to expect at least Node 24.13.

Issue: FEI-7566

Test plan:

  • node -v, see 24.13
  • let CI run checks

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 8, 2026

🦋 Changeset detected

Latest commit: 83cd273

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team April 8, 2026 20:28
@khan-actions-bot
Copy link
Copy Markdown
Contributor

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to package.json, .changeset/spotty-years-stop.md

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Size Change: 0 B

Total Size: 4.22 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.52 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.6 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 1.1 kB

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.15%. Comparing base (74ddde6) to head (83cd273).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1239   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files          63       63           
  Lines         843      843           
  Branches      209      210    +1     
=======================================
  Hits          701      701           
  Misses        142      142           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ddde6...83cd273. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevinb-khan kevinb-khan merged commit 7ca9c0e into main Apr 9, 2026
8 checks passed
@kevinb-khan kevinb-khan deleted the fei-7566.2 branch April 9, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants