Skip to content

Update workflows to use versions of actions that use Node v24#1238

Merged
kevinb-khan merged 3 commits intomainfrom
fei-7601
Apr 7, 2026
Merged

Update workflows to use versions of actions that use Node v24#1238
kevinb-khan merged 3 commits intomainfrom
fei-7601

Conversation

@kevinb-khan
Copy link
Copy Markdown
Contributor

@kevinb-khan kevinb-khan commented Apr 2, 2026

Summary:

Node v20 is exiting its LTS window at the end of April and GitHub is requiring all workflows/actions to use Node v24. Because of this, we need to make sure all of the actions we're using are on v24.

Issue: FEI-7601

Test plan:

  • let CI run and ensure that all checks pass without any warnings about Node v20
Screenshot 2026-04-02 at 5 01 06 PM

I've copy/past'd the one remaining warning below. I think it's safe to ignore this warning.

Starting April 2026, the CodeQL Action will skip computing file coverage information on pull requests to improve analysis performance. File coverage information will still be computed on non-PR analyses.

To opt out of this change, set the CODEQL_ACTION_FILE_COVERAGE_ON_PRS environment variable to true. Alternatively, create a custom repository property with the name github-codeql-file-coverage-on-prs and the type "True/false", then set this property to true in the repository's settings.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 2, 2026

🦋 Changeset detected

Latest commit: d74962c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team April 2, 2026 20:52
@khan-actions-bot
Copy link
Copy Markdown
Contributor

khan-actions-bot commented Apr 2, 2026

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/eighty-pans-repair.md, .github/workflows/codeql-analysis.yml, .github/workflows/dependabot-approve-and-merge.yml, .github/workflows/gerald-pr.yml, .github/workflows/gerald-push.yml, .github/workflows/node-ci-main.yml, .github/workflows/node-ci.yml, .github/workflows/release.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Size Change: 0 B

Total Size: 4.22 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.52 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.6 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 1.1 kB

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.15%. Comparing base (b4918e7) to head (d74962c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1238   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files          63       63           
  Lines         843      843           
  Branches      210      210           
=======================================
  Hits          701      701           
  Misses        142      142           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4918e7...d74962c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@somewhatabstract somewhatabstract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for doing this.

Aside: I think we should probably get things working with SHAs instead of tags in Wonder Stuff at some point.

@kevinb-khan kevinb-khan merged commit 74ddde6 into main Apr 7, 2026
12 checks passed
@kevinb-khan kevinb-khan deleted the fei-7601 branch April 7, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants