[WB-2112] POC - DO NOT REVIEW: Convert TooltipPopper to use floating-ui/react-dom#2818
Closed
[WB-2112] POC - DO NOT REVIEW: Convert TooltipPopper to use floating-ui/react-dom#2818
Conversation
🦋 Changeset detectedLatest commit: e46c107 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: -1.34 kB (-1.23%) Total Size: 107 kB
ℹ️ View Unchanged
|
Contributor
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-ssdipunolq.chromatic.com/ Chromatic results:
|
jandrade
changed the title
Member
Author
|
Moving to "non-draft" to test a snapshot release in |
Contributor
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Contributor
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (7fa7c6d) and published all packages with changesets to npm. You can install the packages in ./dev/tools/deploy_wonder_blocks.js --tag="PR2818"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR2818 |
Member
Author
|
Using a new PR for a better approach: #2826 2826 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2818 +/- ##
============================
============================
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: https://khanacademy.atlassian.net/browse/WB-2112
Test plan:
Navigate to the Tooltip and Popover examples in Storybook and verify that they
behave as expected.