Don't include NI tags when verifying external module data layouts. #60720
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are supposed to be stripped by optimization.
maleadt
added
compiler:codegen
gbaraldi
approved these changes
Jan 16, 2026
Member
|
Does this need 1.12 port as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently excepting callers of
addExternalModuleto provide modules with a DL that contains NI tags:Doing so is invalid and asserts later during compilation:
The NI tags are stripped during optimization, and modules passed to
addExternalModuleare expected to be optimized as they are passed straight to the JIT (as opposed toaddModule), so we should make sure to use the correct data layout.