add support for unified memory #845
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
force-pushed
the
sds/unified_mem
branch
from
b3f2a98 to
f4ac0fe
Compare
See https://rocm.docs.amd.com/projects/HIP/en/latest/how-to/hip_runtime_api/memory_management/unified_memory.html closes JuliaGPU#840 mostly written by Copilot
simeonschaub
force-pushed
the
sds/unified_mem
branch
from
f4ac0fe to
647b71c
Compare
Member
Author
|
Looks like this is not quite enough. If we are to follow CUDA, the stream should be synchronized whenever a regular pointer is taken from unified or host memory. We'll probably have to implement something similar to https://github.com/JuliaGPU/CUDA.jl/blob/7de34f20f8842a256e439941d154f888060504f6/src/memory.jl#L494 for that to have the correct semantics. |
Member
|
Could be needed at this point indeed. If going this way, one should make sure to also provide an opt out mechanism from possible implicit syncing (cf JuliaGPU/CUDA.jl#2662) as this may hinder some use cases as discussed here PTsolvers/Chmy.jl#65. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://rocm.docs.amd.com/projects/HIP/en/latest/how-to/hip_runtime_api/memory_management/unified_memory.html
closes #840
mostly written by Copilot