Skip to content

added: inv! for MovingHorizonEstimator covariance matrices #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

franckgaga
Copy link
Member

@franckgaga franckgaga commented Jun 12, 2025

Allocation-free methods with LinearAlgebra standard types (and numerically robust since it relies on a cholesky factorization, knowing that covariance matrices are positive definite Hermitian matrices).
There is also a fallback method with other AbstractMatrix with some allocations.

Thanks to https://discourse.julialang.org/t/non-allocating-matrix-inversion/62264/14?u=franckgaga for the idea.

allocation-free with `LinearAlgebra` standard types (and numerically robust since it relies on a cholesky factorization)
there is also a fallback method with other `AbstractMatrix` with some allocations
The vector may containt ±Inf value for the MHE and it is not supported by JuMP. The values are updated before optimization anyway.
@franckgaga franckgaga merged commit 61de78d into main Jun 12, 2025
4 checks passed
@franckgaga
Copy link
Member Author

Merging since it passes locally.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.74%. Comparing base (20a5ed0) to head (13387b4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/general.jl 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   98.92%   98.74%   -0.19%     
==========================================
  Files          26       26              
  Lines        4286     4306      +20     
==========================================
+ Hits         4240     4252      +12     
- Misses         46       54       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants