Update Rider UI test to handle new startup behavior

[claude]

Summary

Fixes timeout in Rider UI test by adding wait time after clicking Create button in New Solution dialog.

Problem

The Rider UI test was failing with a timeout when trying to find the IdeFrameImpl after project creation. Analysis of the CI screen recording and UI hierarchy revealed that:

• Rider now shows a "Welcome to JetBrains Rider" screen with a "New Solution" dialog
• After clicking the "Create" button, the dialog takes longer to close
• The test was timing out before the IDE frame could fully initialize

Root Cause

Based on video analysis (screen-recording.mp4) and UI hierarchy dump (hierarchy-ideaVimTest.html):

• At test failure, a FlatWelcomeFrame with "New Solution" dialog (MyDialog) was present
• No IdeFrameImpl was found in the UI hierarchy
• The dialog remained open for the entire test duration (231.9 seconds)

Solution

Added a 15-second wait after clicking the Create button to allow:

• The New Solution dialog to close
• The project to be created on disk
• The IDE frame to fully initialize

This matches similar startup behavior changes in other JetBrains IDEs (see commit 2bf4189 for PyCharm).

Testing

• ✅ Code compiles successfully (./gradlew compileKotlin compileTestKotlin)
• 🔄 CI will verify the fix resolves the timeout issue

Detailed Analysis

A full analysis has been written to build/reports/ai-analysis.txt including:

• Frame-by-frame video analysis
• UI hierarchy examination
• Timeline of events
• Root cause identification

🤖 Generated with Claude Code

[claude]

Code Review

Critical Issues

1. Hard-coded sleep is fragile and inefficient (tests/ui-rd-tests/src/test/kotlin/RiderUiTest.kt:148)

• Using Thread.sleep(15000) wastes 15 seconds every test run, even when dialog closes faster
• RemoteRobot provides waitFor() for polling conditions with timeout
• Should wait for welcome frame to disappear or IDE frame to appear

Suggested fix:

step("Wait for dialog to close") {
  waitFor(duration = Duration.ofSeconds(30)) {
    runCatching { 
      find<WelcomeFrame>(Duration.ofSeconds(1))
      false // Still present
    }.getOrElse { true } // Not found = closed
  }
}

2. Redundant sleep removed without replacement (line 37-38)

• Removed 5s sleep after startNewProject() with no replacement
• Test immediately tries to find IDE frame which may not exist yet
• The 15s sleep is inside welcomeFrame {} block - executes before frame can be found

Flow issue:

startNewProject()  // Returns immediately after dialog closes
// <-- No wait here anymore
idea {  // Tries to find IdeFrameImpl - may fail if not ready
  waitSmartMode()

3. Mixed responsibilities in startNewProject()

• Function both interacts with welcome frame AND waits for its closure
• Wait should be outside welcomeFrame {} block, after it completes
• Current structure makes timing unclear

Minor Issues

4. Inconsistent timeout patterns

• ManageLicensesFrame.kt:32 uses timeout = Duration.ofSeconds(20)
• This code uses raw milliseconds in Thread.sleep()
• Use Duration API for consistency

Recommendations

1. Replace all Thread.sleep() with waitFor() polling
2. Move dialog-closing wait outside welcomeFrame {} block
3. Add explicit wait for IDE frame after startNewProject()
4. Consider adding timeout to idea {} call for clearer error messages

Test Coverage

• No test verifies the fix works
• Relies on CI to validate (acceptable for UI tests)

[claude]

Critical: This sleep executes INSIDE the welcomeFrame {} block before the dialog closes. It won't help the IDE frame appear.

Move this wait outside and use waitFor() instead:

Suggested change

	step("Wait for dialog to close") {
	Thread.sleep(15000)
	}
	// Wait for welcome frame to close and IDE to initialize
	step("Wait for IDE frame") {
	waitFor(duration = Duration.ofSeconds(30)) {
	runCatching { find<IdeaFrame>(Duration.ofSeconds(1)); true }
	.getOrDefault(false)
	}
	}

[claude]

Bug: Removed the 5s sleep but added no replacement. The 15s sleep at line 148 is inside welcomeFrame {} and executes before this idea {} call.

The idea {} call has a 60s timeout (IdeaFrame.kt:23), but may fail immediately if frame doesn't exist. Add explicit wait after startNewProject().