This repository was archived by the owner on Mar 9, 2020. It is now read-only.
_color being null if border tag is empty#463
Open
hassoon3 wants to merge 1 commit intoJanKallman:masterfrom
Open
_color being null if border tag is empty#463hassoon3 wants to merge 1 commit intoJanKallman:masterfrom
hassoon3 wants to merge 1 commit intoJanKallman:masterfrom
Conversation
Hi, In a DevExpress generated excel file, there might be border tags in the style that have no content. Reading like this: <border /> In which case an exception will be thrown. The solution is to check for the Exists property before trying to copy the color. Regards,
|
This, and adding a question mark on get Id in ExcelBorderItemXml.cs will solve my issue with telerik Reporting, #524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In a generated excel file by a DevExpress library, there might be some border tags in the style that have no content. Reading like this (intended tag in bold):
In which case an NullReferenceException will be thrown when accessing _color.Copy()
The recommended and tested solution is to check for the Exists property before trying to copy the color.
I am sorry for not including a Unit Test, as I am still not so fluent in writing them in .Net
Regards,