Skip to content
This repository was archived by the owner on Apr 19, 2018. It is now read-only.

Fix setting dropDownSelector and dropDownHorizontalOffset to IcsSpinner from custom style#625

Open
Alexious-sh wants to merge 1 commit into
JakeWharton:masterfrom
Alexious-sh:fixes
Open

Fix setting dropDownSelector and dropDownHorizontalOffset to IcsSpinner from custom style#625
Alexious-sh wants to merge 1 commit into
JakeWharton:masterfrom
Alexious-sh:fixes

Conversation

@Alexious-sh

Copy link
Copy Markdown

No description provided.

@buildhive

Copy link
Copy Markdown

Jake Wharton » ActionBarSherlock #95 SUCCESS
This pull request looks good
(what's this?)

@JakeWharton

Copy link
Copy Markdown
Owner

Can you detail more about why this is needed? I don't remember having ever seen an issue around this.

@Alexious-sh

Copy link
Copy Markdown
Author

If I remember correct, dropDownSelector style attribute can be used to define drawable, displayed as item background, when it selected by arrow keys. It value ignored by IcsSpinner, but works in real Holo Spinner.

dropDownHorizontalOffset ignored for now too.
When I push this pool request, I develop custom style for spinner, using IcsSpinner from ABS. And it looked better with little bigger margin from left of main element.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants