Skip to content
This repository was archived by the owner on Apr 19, 2018. It is now read-only.

Removing unused declared attributes#1018

Open
jonasfa wants to merge 1 commit into
JakeWharton:masterfrom
jonasfa:unused-attrs
Open

Removing unused declared attributes#1018
jonasfa wants to merge 1 commit into
JakeWharton:masterfrom
jonasfa:unused-attrs

Conversation

@jonasfa

@jonasfa jonasfa commented Aug 21, 2013

Copy link
Copy Markdown

ABS currently declares a number of attributes that are never used.
As they're not useful for neither the library nor developers[1], I think it's reasonable to remove them:

  • listPreferredItemHeightSmall
  • listPreferredItemPaddingLeft
  • listPreferredItemPaddingRight
  • textAppearanceListItemSmall
  • windowMinWidthMajor
  • windowMinWidthMinor
  • actionSpinnerItemStyle
  • horizontalDivider
  • verticalDivider
  • headerBackground
  • windowAnimationStyle
  • itemIconDisabledAlpha

[1] there aren't any values set for them on ABS' themes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant