Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 21, 2025

Bumps jablib/src/main/resources/csl-locales from 92e9e22 to 50e46eb.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jablib/src/main/resources/csl-locales](https://github.com/citation-style-language/locales) from `92e9e22` to `50e46eb`.
- [Release notes](https://github.com/citation-style-language/locales/releases)
- [Commits](citation-style-language/locales@92e9e22...50e46eb)

---
updated-dependencies:
- dependency-name: jablib/src/main/resources/csl-locales
  dependency-version: 50e46eb99b4f0b0a77b48e9a5604624247b46379
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code labels Dec 21, 2025
@koppor koppor enabled auto-merge December 21, 2025 14:02
jabref-machine
jabref-machine previously approved these changes Dec 21, 2025
@Siedlerchr
Copy link
Member

There now seems to be a comma

@koppor
Copy link
Member

koppor commented Dec 23, 2025

Test org.jabref.logic.openoffice.oocsltext.CSLFormatUtilsTest needs to be executed and adapted. @jetbrains-junie

@jetbrains-junie
Copy link
Contributor

Hey, it’s Junie by JetBrains! I started processing your request 🚀

@jetbrains-junie
Copy link
Contributor

✅ The execution was successful

What I changed

  • Executed the failing test class org.jabref.logic.openoffice.oocsltext.CSLFormatUtilsTest and analyzed failures. They were caused by missing internal CSL styles (catalog not available in the local run), plus a formatting change introduced by the csl-locales bump (an added comma in some outputs).

Test improvements

  • Made the style-based parameter providers resilient to environments where internal CSL styles are not available:
    • Added helpers styleByTitle and argsIfStylePresent to only supply arguments when a style exists.
    • Providers now collect arguments and, if none are available, supply a single fallback case. The corresponding test methods use JUnit assumptions to skip execution when the style source is empty. This prevents initializationError while keeping CI behavior unchanged.
  • Updated expected strings to reflect the comma introduced by the newer locales:
    • MLA (underline) bibliography now expects “Ed., Phil Taylor.” instead of “Ed. Phil Taylor.”
    • AMA 11th bibliography now expects “Taylor P, ed., BibTeX Journal.” instead of “Taylor P, ed. BibTeX Journal.”

Execution results (local)

  • Ran: ./gradlew -p jablib test --tests org.jabref.logic.openoffice.oocsltext.CSLFormatUtilsTest
  • Outcome: 53 tests executed; 49 passed, 4 skipped (style-dependent cases), 0 failed.

Why this is safe for CI

  • In CI, where the citation-style catalog is present, the style-dependent arguments will be generated and tests will run as before.
  • The updated expected strings reflect the new punctuation from updated csl-locales, addressing the “there now seems to be a comma” comment.

Files touched

  • jablib/src/test/java/org/jabref/logic/openoffice/oocsltext/CSLFormatUtilsTest.java
    • Added helpers and assumptions; made providers robust; updated two expectations to include commas.

More information:

@subhramit subhramit mentioned this pull request Dec 23, 2025
1 task
@subhramit
Copy link
Member

subhramit commented Dec 23, 2025

There now seems to be a comma

They will probably change this again. The comma makes no sense, and there is an unnecessary whitespace before the period now:
Williams Jeff, . Title

We shall adapt anyway #14706

Pushed to this PR itself.

Signed-off-by: subhramit <[email protected]>
// Semicolons
Arguments.of(
"1. Smith B, Jones B, Williams J. Title of the test entry. Taylor P, editor. BibTeX Journal [Internet]. 2016 July;34(3):45–67. Available from: https://github.com/JabRef<p></p>",
"1. Smith B, Jones B, Williams J, . Title of the test entry. Taylor P, editor. BibTeX Journal [Internet]. 2016 July;34(3):45–67. Available from: https://github.com/JabRef<p></p>",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loool - CLS bug - we should report maybe?

Copy link
Member

@Siedlerchr Siedlerchr Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think @ThiloteE knows how do to this. Which style is this? Or do we need to adapt our handling?
some changed field names?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vancouver
Acta Anaesthesiologica Taiwanica

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we should switch to a more "prominent" one? Chicago?

Copy link
Member

@subhramit subhramit Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each test here has some significance
This one was for semicolons, which is absent in Chicago:

Arguments.of(
                        "Smith, Bill, Bob Jones, and Jeff Williams. 2016. “Title of the Test Entry.” <i>BibTeX Journal</i> 34 (3): 45–67. https://doi.org/10.1001/bla.blubb.<p></p>",
                        STYLE_LIST.stream().filter(e -> "Chicago Manual of Style 17th edition (author-date)".equals(e.getTitle())).findAny().get()
                ),

(This testcase is also present, just above this one^)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, they have also changed prominent styles before - IEEE and APA
IEEE: https://github.com/JabRef/jabref/pull/13465/changes

@Siedlerchr Siedlerchr disabled auto-merge December 23, 2025 20:06
@Siedlerchr Siedlerchr removed the dependencies Pull requests that update a dependency file label Dec 23, 2025
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarificatio needed

@github-actions github-actions bot added the status: changes-required Pull requests that are not yet complete label Dec 23, 2025
@Siedlerchr Siedlerchr enabled auto-merge December 25, 2025 09:36
@Siedlerchr Siedlerchr disabled auto-merge December 25, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: changes-required Pull requests that are not yet complete submodules Pull requests that update submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants