-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Chore(deps): Bump jablib/src/main/resources/csl-locales from 92e9e22 to 50e46eb
#14677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Chore(deps): Bump jablib/src/main/resources/csl-locales from 92e9e22 to 50e46eb
#14677
Conversation
Bumps [jablib/src/main/resources/csl-locales](https://github.com/citation-style-language/locales) from `92e9e22` to `50e46eb`. - [Release notes](https://github.com/citation-style-language/locales/releases) - [Commits](citation-style-language/locales@92e9e22...50e46eb) --- updated-dependencies: - dependency-name: jablib/src/main/resources/csl-locales dependency-version: 50e46eb99b4f0b0a77b48e9a5604624247b46379 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…ces/csl-locales-50e46eb
|
There now seems to be a comma |
|
Test |
|
Hey, it’s Junie by JetBrains! I started processing your request 🚀 |
✅ The execution was successful
More information: |
They will probably change this again. The comma makes no sense, and there is an unnecessary whitespace before the period now:
Pushed to this PR itself. |
Signed-off-by: subhramit <[email protected]>
| // Semicolons | ||
| Arguments.of( | ||
| "1. Smith B, Jones B, Williams J. Title of the test entry. Taylor P, editor. BibTeX Journal [Internet]. 2016 July;34(3):45–67. Available from: https://github.com/JabRef<p></p>", | ||
| "1. Smith B, Jones B, Williams J, . Title of the test entry. Taylor P, editor. BibTeX Journal [Internet]. 2016 July;34(3):45–67. Available from: https://github.com/JabRef<p></p>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loool - CLS bug - we should report maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think @ThiloteE knows how do to this. Which style is this? Or do we need to adapt our handling?
some changed field names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vancouver
Acta Anaesthesiologica Taiwanica
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, we should switch to a more "prominent" one? Chicago?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each test here has some significance
This one was for semicolons, which is absent in Chicago:
Arguments.of(
"Smith, Bill, Bob Jones, and Jeff Williams. 2016. “Title of the Test Entry.” <i>BibTeX Journal</i> 34 (3): 45–67. https://doi.org/10.1001/bla.blubb.<p></p>",
STYLE_LIST.stream().filter(e -> "Chicago Manual of Style 17th edition (author-date)".equals(e.getTitle())).findAny().get()
),(This testcase is also present, just above this one^)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides, they have also changed prominent styles before - IEEE and APA
IEEE: https://github.com/JabRef/jabref/pull/13465/changes
Siedlerchr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarificatio needed
Bumps jablib/src/main/resources/csl-locales from
92e9e22to50e46eb.Commits
50e46ebEt ee available at translation (#404)2e12206Revise translations in locales-id-ID.xml (#399)90376eeCleanup locales (resolve #400) (#401)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)