-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fixed search result focus handling #13174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r a fulltext search; fixed also an issue where sometimes the search results tab would be empty after a successful search
…ltext search; fixed also an issue where sometimes the search results tab would be empty after a successful search
@trag-bot didn't find any issues in the code! ✅✨ |
@koppor determine issue number check failed https://github.com/JabRef/jabref/actions/runs/15281990665/job/42983040404?pr=13174 |
Contributor used NOTE THAT THE LINK POINTS TO ANOITHER ISSUE
Update I needed to fix the job name - 5b5cba8 |
Your pull request needs to link an issue. To ease organizational workflows, please link this pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue:
Examples
|
@@ -88,14 +92,20 @@ protected void bindToEntry(BibEntry entry) { | |||
} | |||
this.entry = entry; | |||
updateSearch(); | |||
notifyAboutFocus(entry); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that this is needed? - I think, Platform.runLater(entryEditor::adaptVisibleTabs)
could be directly called - or another method adaptVisisbleTabs()
containing this call could be used. focus
is wrong IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually is not needed, just tested it. Sorry I'm just starting to get familiar with JavaFX.
None, 1 out of 10 is a bearable edge case. I think this is rarer than 1 out of 10. |
Closes #12856
Implemented handleFocus() in FulltextSearchResultsTab , now search results tab shows correctly after a fulltext search, and disappear after the fulltextsearch flag is disabled; fixed also an issue where sometimes the search results tab would be empty after a successful search.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)