Skip to content

Fixed search result focus handling #13174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ZodGaz
Copy link

@ZodGaz ZodGaz commented May 27, 2025

Closes #12856
Implemented handleFocus() in FulltextSearchResultsTab , now search results tab shows correctly after a fulltext search, and disappear after the fulltextsearch flag is disabled; fixed also an issue where sometimes the search results tab would be empty after a successful search.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

ZodGaz added 2 commits May 27, 2025 19:05
…r a fulltext search; fixed also an issue where sometimes the search results tab would be empty after a successful search
…ltext search; fixed also an issue where sometimes the search results tab would be empty after a successful search
Copy link

trag-bot bot commented May 27, 2025

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr changed the title fixed issue #12856 Fixed search result focus handling May 27, 2025
@subhramit
Copy link
Member

@koppor
Copy link
Member

koppor commented May 27, 2025

@koppor determine issue number check failed JabRef/jabref/actions/runs/15281990665/job/42983040404?pr=13174

Contributor used Closes [#12856](https://github.com/JabRef/jabref/issues/12865). One out of 10 persons use this strange format. One year ago, we had a help text on it that people should just add the number, or the link - and not both.

NOTE THAT THE LINK POINTS TO ANOITHER ISSUE

  • Option A: We try to parse also these kind of things - and also report errors if the link text does not match the issue number
  • Option B: Refine the comment text 😅

Update I needed to fix the job name - 5b5cba8

@jabref-machine
Copy link
Collaborator

Your pull request needs to link an issue.

To ease organizational workflows, please link this pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue:

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

Examples

  • Fixes #xyz links pull-request to issue. Merging the PR will close the issue.
  • Fixes https://github.com/JabRef/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
  • Fixes https://github.com/Koppor/jabref/issues/xyz links pull-request to issue. Merging the PR will close the issue.
  • Fixes [#xyz](https://github.com/JabRef/jabref/issues/xyz) links pull-request to issue. Merging the PR will NOT close the issue.

@koppor koppor mentioned this pull request May 27, 2025
1 task
@@ -88,14 +92,20 @@ protected void bindToEntry(BibEntry entry) {
}
this.entry = entry;
updateSearch();
notifyAboutFocus(entry);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that this is needed? - I think, Platform.runLater(entryEditor::adaptVisibleTabs) could be directly called - or another method adaptVisisbleTabs() containing this call could be used. focus is wrong IMHO.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually is not needed, just tested it. Sorry I'm just starting to get familiar with JavaFX.

@subhramit
Copy link
Member

  • Option A: We try to parse also these kind of things - and also report errors if the link text does not match the issue number
  • Option B: Refine the comment text 😅

None, 1 out of 10 is a bearable edge case. I think this is rarer than 1 out of 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Search results" tab should be shown during fulltext search
4 participants