-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add consistency check dialog box #13081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jabgui/src/main/java/org/jabref/gui/consistency/ConsistencyCheckAction.java
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/consistency/ConsistencyCheckAction.java
Show resolved
Hide resolved
jabgui/src/main/java/org/jabref/gui/consistency/ConsistencyCheckAction.java
Show resolved
Hide resolved
|
Looks ok so far. Please add a changelog entry! |
|
@Bha2912 Please fix localization - see https://devdocs.jabref.org/code-howtos/localization.html for help |
| Task<BibliographyConsistencyCheck.Result> task = new Task<>() { | ||
| protected BibliographyConsistencyCheck.Result call() throws Exception { | ||
| BibDatabaseContext databaseContext = stateManager.getActiveDatabase() | ||
| .orElseThrow(() -> new NullPointerException("Database null")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using exceptions for control flow is not recommended. Instead, handle the absence of a database more gracefully without throwing a NullPointerException.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jsut use get() or - even better: stateManager.getActiveDatabase().ifpresent( ...)
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
You committed your code on the For this pull request, this is OK. For subsequent pull requests, please start with a different branch with a proper branch name. See CONTRIBUTING.md for more details. |
koppor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Superseded by #13181 |


Closes #12487
This PR introduce GUI dialog box that will show consistency check result with progress e.g 1 entry out of 123456...
Screenshot
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)