-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix JabRef-post-image.wsf to make it agnostic to the location of the … #13033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix JabRef-post-image.wsf to make it agnostic to the location of the … #13033
Conversation
…project build directory
Thanks for the contribution! Looks good from my side. Would you please resolce the conflicts then we can merge it! |
Due to the modularization which we merged after the alpha, the jpackage resources are now under jabgui/buildres/windows and in the corresponding build gradle file. |
Right, but there is no JabRef-post-image.wsf script in these resources anymore. Instead, there is "main.wxs". If this is a permanent fix and not a temporary workaround for jpackage's bug in JDK24, then this pull request can be discarded. Otherwise, I can merge and integrate it later. |
I totally overlooked that it was integrated into the main.wxs now. I think it was originally meant to be a workaround by @koppor but could be a permanent solution now as well if it works as intended. |
I think, we should get this in. The idea of the script was IMHO: Take the JDK generated main.w... file as "leading X and add necessary things afterwards. I will try to take care later. (And @alexeysemenyukoracle thank you so much for the time invested!) |
As far as I understood openjdk/jdk#19318 (comment) and https://bugs.openjdk.org/browse/JDK-8355651, we should update to JDK25 to have the script working again? 😅 |
Blocked by:
Debugging more:
Wishes: |
@trag-bot didn't find any issues in the code! ✅✨ |
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of |
Windows:
The ChatGPT-solution (dc293db) seems to be wired... Needs more investigation. |
I'd stick to the current workaround with "main.wxs" and revisit this PR later when you decide to migrate to a newer JDK version. |
Fix JabRef-post-image.wsf script to make it independent of the project build location.
Build-only change to eliminate dependencies on the context in which the "post-image" jpackage script is called on Windows.
Closes #13034
Important: the baseline for the fix is
v6.0-alpha2
tag. There is no JabRef-post-image.wsf in the main branch after #12990, so this PR can not be integrated as-is.Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)