-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix issue #11189 - Implement a caching solution with local storage for citation relations #11845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
calixtus
merged 79 commits into
JabRef:main
from
alexandre-cremieux:fix-issue-11189-part-00-refactor-citation-relation-tab-logic
Jun 7, 2025
Merged
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
3785cb1
Refactor Citations Relations Tab (#11189)
alexandre-cremieux 8048da8
Refactor Citations Relations Tab (#11189)
alexandre-cremieux 18db75e
Refactor Citations Relations Service Layer (#11189)
alexandre-cremieux 0e9de3c
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
koppor 9a31735
Address PR comments (#11901)
alexandre-cremieux b1133d0
MVStore implementation for citations: first approach (wip for open di…
alexandre-cremieux 6a8b21b
Introduce the DAO layer for relations (#11189):
alexandre-cremieux 01f6da4
MVStoreDAO implementation for citations relations (#11189):
alexandre-cremieux 337780d
Implement a search lock mechanism for citations relations (#11189):
alexandre-cremieux 7c2e32d
Avoid user to force update citation relations even the fetcher return…
alexandre-cremieux 187b5d4
Make the citation relations update automatic after the guard delay is…
alexandre-cremieux b71d9fc
SearchCitationsRelationsService as singleton
dda21ed
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
077e9ca
Update failing tests after merge
0bff913
Clean code style according to checkstyle
ea36f1a
Clean code style according to checkstyle
d7f9c2d
Fix pending PR comments
97b38c6
Fix null pointer exception in CitationsRelationsTab
54e7e21
Add settings for Citations relations store TTL
6415b1b
Update MVStoreBibEntryRelationDAO serializer/deserializer
e18d557
Update CHANGELOG-MD for Citations relations tab caching logic (#11189)
57b5c02
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
16cfd2c
Return an empty BibEntry from MVStoreBibEntryRelationDAO in case of p…
33f5cdf
Add a test to ensure that an empty list is returned from in case of s…
2ebf62e
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
6861ae2
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
393b133
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
e8e223d
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
5727ecb
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
koppor 0cdf495
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
48c48ad
fix typo (#11189)
7af20c3
Address CHANGE_LOG follwing review (#11189)
eb3dfd8
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
14ab672
Add comments for tests helpers (#11189)
061bb89
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
76b2289
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
koppor a36acd4
Improve BibEntries for test (more confirming to BibTeX)
koppor 8893936
Fix variable name
koppor 37354f5
Streamline code
koppor b3e1746
Fix class names: "Repository" instead of DAO
koppor 24c1707
Make test BibTeX more consistent to "normal" BibTeX
koppor d3cac8b
Add comment on test constructor
koppor deab9b5
Fix class name (not being imperative any more)
koppor e40637b
Merge branch 'fix-issue-11189-part-00-refactor-citation-relation-tab-…
koppor 543c48b
Fix method name
koppor a2d3856
Use annotations instead of JavaDoc comments
koppor 31cd171
Add FIXME
koppor 2d31d0f
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
koppor 5bdc850
Add JavaDoc comment
c03d1f5
Add JavaDoc comment
koppor 4b33bfa
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
d82ab8c
Update CHANGE_LOG
e9ac90e
Remove the LRU cache layer
10a1d6a
Simplify repositories naming
033b296
Open the MVStore once and close it only at application shutdown
59a2d24
Checkstyle corrections
4ffd652
Fix MD checks
7a81e73
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
70895c0
Merge remote-tracking branch 'origin/main' into fix-issue-11189-part-…
koppor e2f0844
Fix serialization and lifecycle
calixtus 0b67868
Fix handling of null response from server
calixtus 85835d9
Fix imports
calixtus 1b5977e
Fix injection
calixtus bcaf43f
Fix tests
calixtus 873b134
Adapt heap space for test on ci
calixtus bdd103b
Refactor
subhramit c58a072
Fix one parameter
subhramit c16d4ad
One line for two parameters
subhramit 2f09c3a
Fixes module exports
calixtus c23bf0e
Merge remote-tracking branch 'alexandre-cremieux/fix-issue-11189-part…
calixtus 73e5ea6
Unnecessary `this`
subhramit 8a2a93f
Merge branch 'main' into fix-issue-11189-part-00-refactor-citation-re…
koppor e70fa74
Try hacky solution for MVStore usage
koppor a50ab07
Try 6GB
koppor 496fbad
Add System.gc() call
koppor 7b5bd76
Add plus one second in the test
koppor 162888d
Disable on CI
calixtus e148226
Merge remote-tracking branch 'alexandre-cremieux/fix-issue-11189-part…
calixtus 890dfdb
Revert quickhack
calixtus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 0 additions & 39 deletions
39
.../src/main/java/org/jabref/gui/entryeditor/citationrelationtab/BibEntryRelationsCache.java
This file was deleted.
Oops, something went wrong.
73 changes: 0 additions & 73 deletions
73
...main/java/org/jabref/gui/entryeditor/citationrelationtab/BibEntryRelationsRepository.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.