Fix help text of URL options to list the actually supported schemes#1396
Open
palas wants to merge 1 commit into
Open
Fix help text of URL options to list the actually supported schemes#1396palas wants to merge 1 commit into
palas wants to merge 1 commit into
Conversation
The help for `hash anchor-data --url` claimed that only HTTP(S) and IPFS URLs are supported, but the URL is fetched with `allSchemes`, which also accepts file:// URLs. Conversely, `--pool-metadata-url` (`stake-pool metadata-hash`) and `--drep-metadata-url` (`governance drep metadata-hash`), which are also fetched with `allSchemes`, did not document which schemes they accept at all.
palas
requested review from
Jimbo4350,
carbolymer,
disassembler,
kevinhammond and
newhoggy
as code owners
July 18, 2026 04:44
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Cardano CLI option help text so URL-taking commands accurately document the URL schemes they support (matching the underlying use of allSchemes).
Changes:
- Document supported URL schemes (
file,http,https,ipfs) forhash anchor-data --url. - Document supported URL schemes for
stake-pool metadata-hash --pool-metadata-urlandgovernance drep metadata-hash --drep-metadata-url. - Update golden help fixtures and add a changelog fragment.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cardano-cli/test/cardano-cli-golden/files/golden/help/latest_stake-pool_metadata-hash.cli | Updates golden help output to include supported schemes for --pool-metadata-url. |
| cardano-cli/test/cardano-cli-golden/files/golden/help/latest_governance_drep_metadata-hash.cli | Updates golden help output to include supported schemes for --drep-metadata-url. |
| cardano-cli/test/cardano-cli-golden/files/golden/help/hash_anchor-data.cli | Updates golden help output to reflect broader supported schemes for --url. |
| cardano-cli/test/cardano-cli-golden/files/golden/help/conway_stake-pool_metadata-hash.cli | Updates Conway-era golden help output for --pool-metadata-url. |
| cardano-cli/test/cardano-cli-golden/files/golden/help/conway_governance_drep_metadata-hash.cli | Updates Conway-era golden help output for --drep-metadata-url. |
| cardano-cli/test/cardano-cli-golden/files/golden/help/compatible_conway_governance_drep_metadata-hash.cli | Updates compatible-Conway golden help output for --drep-metadata-url. |
| cardano-cli/src/Cardano/CLI/EraIndependent/Hash/Option.hs | Updates hash anchor-data --url help string to list supported schemes. |
| cardano-cli/src/Cardano/CLI/EraBased/StakePool/Option.hs | Updates --pool-metadata-url help string to list supported schemes. |
| cardano-cli/src/Cardano/CLI/EraBased/Governance/DRep/Option.hs | Updates --drep-metadata-url help string to list supported schemes. |
| .changes/20260718_044307_cardano-cli_pablo.lamela_fix_anchor_url_help_messages.yml | Adds changelog fragment for the help-text update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+2
| description: Fix help messages in anchor hashing functions to display the right protocols | ||
| supported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The help for
hash anchor-data --urlclaimed that only HTTP(S) and IPFS URLs are supported, but the URL is fetched withallSchemes, which also accepts file:// URLs. Conversely,--pool-metadata-url(stake-pool metadata-hash) and--drep-metadata-url(governance drep metadata-hash), which are also fetched withallSchemes, did not document which schemes they accept at all.This PR updates the help for these command so that it correctly describes the supported schemas.
How to trust this PR
Check the messages are written correctly and that the implementation of these commands indeed use
allSchemes.Checklist
.changes/