Skip to content

Fix the program hang caused by duplicate serialization#1949

Merged
hhaAndroid merged 1 commit into
InternLM:mainfrom
hhaAndroid:fix_sp_rl
Jul 15, 2026
Merged

Fix the program hang caused by duplicate serialization#1949
hhaAndroid merged 1 commit into
InternLM:mainfrom
hhaAndroid:fix_sp_rl

Conversation

@hhaAndroid

Copy link
Copy Markdown
Collaborator

No description provided.

@hhaAndroid

Copy link
Copy Markdown
Collaborator Author

@claude approve

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The fix correctly deduplicates Ray object serialization by using explicit ray.put() with a data_batch_refs cache keyed by dp_idx. Previously, each worker in the same data-parallel group would implicitly serialize the same data slice via .remote(), causing redundant serialization that could lead to hangs. The cleanup with del data_batch_refs in the finally block is also appropriate.

@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Claude: Approved PR #1949 as requested.

What was requested: Approve the PR.

Actions taken: Reviewed the diff and approved with comments. The fix correctly addresses a program hang caused by duplicate Ray object serialization — workers in the same data-parallel group now share a single ray.put() object ref instead of each implicitly serializing the same data slice via .remote().

@hhaAndroid hhaAndroid merged commit e87ad87 into InternLM:main Jul 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant