Skip to content

Conversation

@sandlbn
Copy link
Contributor

@sandlbn sandlbn commented Jun 11, 2025

Add PartialEq derive to HashAlgorithm enum to enable direct comparison between algorithm variants. This is needed for signature verification logic where we need to ensure the signing and verification algorithms match.

Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

name = "atlas-c2pa-lib"
version = "0.1.0"
version = "0.1.1"
edition = "2021"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I'm here ;)

Suggested change
edition = "2021"
edition = "2024"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update it in the next PR, as cargo fmt will fail.

@sandlbn sandlbn merged commit ea16655 into main Jun 11, 2025
2 checks passed
@sandlbn sandlbn deleted the ms-hash-partial branch June 11, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants