Skip to content

Revert "Fix bug where width padding was applied twice" #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RobLoach
Copy link
Contributor

@RobLoach RobLoach commented Apr 5, 2025

Going through the commits, I found this commit is what was causing some border issues on the button. Mind testing this out?

Coming from #796

This reverts commit 14dd68e.

Looks like there's still something wrong with the window padding, but it does fix the button border.

master

Screenshot from 2025-04-05 00-58-45

border-padding

Screenshot from 2025-04-05 00-59-06

@klei1984
Copy link

klei1984 commented Apr 5, 2025

I tested sdl_opengl3 and glfw_opengl4, both with anti aliasing (AA) on and off.

The left side is now not truncated, but the right side conditionally is. On master the following behavior is not observed, on this branch it is consistent on the two demos tested. Screenshot is taken from glfw_opengl4 with AA off:
kép

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants