[PHP 8.4] Fixes for implicit nullability deprecation #208
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes all issues that emits a deprecation notice on PHP 8.4. See: - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types) - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
|
Was about to submit the same.. Simple fix, ensures PHP 8.4 while being backwards compatible |
|
please merge this |
|
bump @Imangazaliev |
Contributor
|
Hello @Imangazaliev, can you please merge this? |
jadeops
added a commit
to revivecode/DiDOM
that referenced
this pull request
Feb 1, 2025
|
Why that fix still not merged? |
|
I just emailed the maintainer. |
This was referenced Jun 17, 2025
|
@Imangazaliev Hi, can you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all issues that emits a deprecation notice on PHP 8.4.
See: