CMake tweaks and cleanup to help with alps uenv builds #358
Conversation
gitignore for merge file backups etc
|
I like those changes a lot, nice! |
| # Module path | ||
| # ------------------------------------------------------------------------------ | ||
| list(PREPEND CMAKE_MODULE_PATH | ||
| "${PROJECT_SOURCE_DIR}/cmake" "${PROJECT_SOURCE_DIR}/CMakeModules") |
There was a problem hiding this comment.
Do we want both a cmake and a CMakeModules folder? It might be more clean to have a folder-hierarchy all inside the cmake folder? Or what would the arguments be for having both?
There was a problem hiding this comment.
I think that I just didn't notice there was the CMakeModules there - it doesn't exist on my tree, so is it a left over from somewhere, or should it be present. Probably I just added the cmake and missed the other, we can/should certainly remove one
There was a problem hiding this comment.
From what I can see there is no official recommendation what name one should choose here but I've looked at some more modern projects and they mainly seem to be using "cmake" so I'd suggest using just that one?
No description provided.