Skip to content

fix: use relation id instead of array index as key in RelationsList #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

lusterck
Copy link

@lusterck lusterck commented Jun 8, 2025

Reason for change: fixes #7716

Replaces array index with relation.id as the key prop for RelationItem components to prevent potential rendering issues when relations are reordered or updated.

Copy link

netlify bot commented Jun 8, 2025

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 191970e

Copy link

netlify bot commented Jun 8, 2025

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 191970e

Copy link

netlify bot commented Jun 8, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 191970e
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/684f95387bdf870008d25f6d
😎 Deploy Preview https://deploy-preview-7721--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jun 8, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 191970e
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/684f9538c86ddb00089f9402
😎 Deploy Preview https://deploy-preview-7721--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the fix label Jun 8, 2025
@lusterck lusterck marked this pull request as ready for review June 8, 2025 14:31
@lusterck
Copy link
Author

@nick-skriabin Thank you for reviewing.

I assume because this is my first contribution, the workflows still require approval from a maintainer.
Is there anything else I can provide here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants