This repository was archived by the owner on Apr 18, 2024. It is now read-only.
feat: DEV-2786: Adjustable draggable spans #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create selection with the same style as span at the selection start. This emulates span expansion by dragging from its edge.
- copy styles from span to selection - remember offsets - grey out the original span
…cted, change label to be over text and disappear on hover
…ove selection style functions
|
✅ Linked to DEV-2786 · Adjustable/draggable spans implementation |
nick-skriabin
suggested changes
Jul 18, 2022
Member
There was a problem hiding this comment.
Found a couple of issues with the feature. Reported in #code-reviews.
…drag makes selection dragging and resize smooth
…eartexlabs/label-studio-frontend into fb-dev-2786/adjustable-draggable-spans
Use removeHighlight() and applyHighlight() for this. Fix removeHighlight() to do a good clean up.
It was impossible to drag small region because of resize handlers. Moving them outside of the span solves the problem.
bmartel
previously requested changes
Sep 1, 2022
Contributor
bmartel
left a comment
bmartel
left a comment
There was a problem hiding this comment.
Looks great! Just a few suggestions to remove commented out code.
…eartexlabs/label-studio-frontend into fb-dev-2786/adjustable-draggable-spans
nick-skriabin
approved these changes
Sep 5, 2022
nick-skriabin
dismissed
bmartel’s stale review
Suggested changes were applied.
Collaborator
|
/git merge master
|
…ble-draggable-spans
…ble-draggable-spans
…ble-draggable-spans
Collaborator
|
/git merge master
|
…ble-draggable-spans
…ble-draggable-spans
remove console
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add grabber handles on the front and back of each span, improve data label to allow for smoother drag, hide span on drag, replacing with selection of the same color, delete span on new range creation.